Skip to content

dd: error if iflag=directory and input is stdin #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

dd: error if iflag=directory and input is stdin #7122

merged 1 commit into from
Jan 13, 2025

Conversation

jfinkels
Copy link
Collaborator

@jfinkels jfinkels commented Jan 11, 2025 •
edited
Loading

Make dd error if iflag=directory and the input file is not a
directory, as in

: | dd iflag=directory

Fixes #5900

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/dd/misc. tests/dd/misc is passing on 'main'. Maybe you have to rebase?

@jfinkels jfinkels marked this pull request as draft January 11, 2025 22:02
@jfinkels
Copy link
Collaborator Author

I guess it's not quite right, back to draft.

@jfinkels jfinkels force-pushed the dd-error-iflag-directory branch 2 times, most recently from 4f11655 to 55fcb5b Compare January 12, 2025 20:15
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@jfinkels jfinkels force-pushed the dd-error-iflag-directory branch from 55fcb5b to 1c8582e Compare January 12, 2025 21:16
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@jfinkels jfinkels force-pushed the dd-error-iflag-directory branch from 1c8582e to 8871339 Compare January 12, 2025 22:27
@jfinkels jfinkels marked this pull request as ready for review January 12, 2025 22:28
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@jfinkels @sylvestre
dd: error if iflag=directory and input is stdin
d9b3b3e 
Make `dd` error if `iflag=directory` and the input file is not a
directory, as in

    : | dd iflag=directory

Fixes uutils#5900
@sylvestre sylvestre force-pushed the dd-error-iflag-directory branch from 8871339 to d9b3b3e Compare January 13, 2025 08:36
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/misc/stdbuf is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 40511f6 into uutils:main Jan 13, 2025
65 checks passed
@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dd: should error on reading stdin when iflag=directory option is given
2 participants
@jfinkels @sylvestre