Skip to content

numfmt: use succeeds()/fails() instead of run() in tests #7135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

numfmt: use succeeds()/fails() instead of run() in tests #7135

merged 1 commit into from
Jan 14, 2025

Conversation

cakebaker
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/stdbuf is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

i wonder if we could prevent this coding pattern...

@sylvestre sylvestre merged commit 1ffb6fd into uutils:main Jan 14, 2025
65 checks passed
@cakebaker cakebaker deleted the numfmt_replace_run branch January 15, 2025 06:14
@cakebaker
Copy link
Contributor Author

I think it is mainly a copy & paste issue. In a future PR I will replace run() in the other tests where possible.

@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre