Skip to content

comm: don't use files for test #7140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

comm: don't use files for test #7140

merged 1 commit into from
Jan 15, 2025

Conversation

sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Jan 15, 2025 •
edited
Loading

having the content and expected results helps a lot to debug

@sylvestre sylvestre requested a review from cakebaker January 15, 2025 09:28
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/dircolors is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

cakebaker
cakebaker reviewed Jan 15, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jan 15, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit dca0ec0 into uutils:main Jan 15, 2025
48 of 49 checks passed
@cakebaker
Copy link
Contributor

Yes, I agree, the tests are much easier to read without the fixtures. Thanks for removing them :)

@sylvestre sylvestre deleted the comm-test branch January 15, 2025 15:43
@sylvestre
Copy link
Contributor Author

Thanks. i wonder if we should do that for other programs

@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker