-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
printf: improve support of printing multi-byte values of characters #7208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GNU testsuite comparison:
|
I was worried because, unlike #7048, this doesn't get the printf-mb GNU test to pass, but on closer investigation, the test was only passing due to a coincidental bug that made it pass, despite failing in the general case. The problem is the same described here: #7048 (comment) |
To be clear for posterity, the version in this PR will look correct and show |
Force push is a rebase on main. |
aacad95
to
1a16a34
Compare
GNU testsuite comparison:
|
@sylvestre: Do you expect this to merge soon? If not, I can just pause the rebases until you ping me. |
@jtracey sorry, i missed your message :( |
yeah, it looks good! |
GNU testsuite comparison:
|
@sylvestre No worries. :) Should be good to merge now. |
@sylvestre ping |
thanks for the ping |
Based on #7048.