-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
flake: drop flake-utils, refactor #7368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for refactoring this. I'm no expert in Nix, and I'm happy to see it used and maintained.
The changes looks good to me 👍
GNU testsuite comparison:
|
export PATH=$PATH:''${RUSTUP_HOME:-~/.rustup}/toolchains/$RUSTC_VERSION-x86_64-unknown-linux-gnu/bin/ | ||
''; | ||
RUSTC_VERSION = "1.79"; | ||
LIBCLANG_PATH = pkgsFor.${system}.lib.makeLibraryPath [pkgsFor.${system}.llvmPackages_latest.libclang.lib]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use rustPlatform.bindgenHook
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, how would I go about doing that?
acl | ||
]; | ||
|
||
build_deps = with pkgsFor.${system}; [ | ||
clang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably use clangStdenv
for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? What is the difference? I guess it includes more stuff which might be needed?
A small step for uutils, but a large step for the Nix community 🎉 |
This isn't usable under darwin, fyi. |
Please make a new issue with the problem, I'd be glad to take a look at it! |
I have tested basic functionality and it should function just the same as before.