Skip to content

Fix coverage files generation #7401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 7, 2025
Merged

Fix coverage files generation #7401

merged 6 commits into from
Apr 7, 2025

Conversation

RenjiSann
Copy link
Collaborator

@RenjiSann RenjiSann commented Mar 5, 2025 •
edited
Loading

Fixes #7282 issue about LLVM instrumentation.

The remain BIG issue is that the quantity of trace files generated by the WHOLE testsuite is absolutely massive, because 1 call to the tested binary produces 1 trace file that is around 5 MiB.
On my machine, the testsuite had to stop at ~80% completion because it had filled my disk with 92GiB of .profraw files.

@RenjiSann RenjiSann force-pushed the coverage branch 2 times, most recently from 09a916d to 9020634 Compare March 5, 2025 01:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

having at least linux passing would be an improvement! :)

@RenjiSann RenjiSann force-pushed the coverage branch 2 times, most recently from ab91264 to 4f801c9 Compare March 5, 2025 11:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)

@RenjiSann RenjiSann force-pushed the coverage branch 3 times, most recently from 66fd2fa to 5812e9c Compare March 5, 2025 14:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@RenjiSann RenjiSann force-pushed the coverage branch 8 times, most recently from cc00e9b to 51e845c Compare March 5, 2025 16:10
@RenjiSann
Copy link
Collaborator Author

FINALLY it seems to work. However, there is still a problem with result upload on codecov

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@RenjiSann RenjiSann marked this pull request as draft March 6, 2025 11:51
@RenjiSann RenjiSann force-pushed the coverage branch 2 times, most recently from 4178c97 to 1545a9b Compare March 10, 2025 22:57
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/stdbuf is no longer failing!

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@RenjiSann RenjiSann force-pushed the coverage branch 3 times, most recently from 69f4925 to 8997ebf Compare April 4, 2025 16:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@RenjiSann RenjiSann force-pushed the coverage branch 2 times, most recently from f344644 to 47b2096 Compare April 4, 2025 17:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@RenjiSann RenjiSann marked this pull request as ready for review April 7, 2025 08:19
@RenjiSann
Copy link
Collaborator Author

@sylvestre this is ready to review ^^

sylvestre
sylvestre reviewed Apr 7, 2025
View reviewed changes
@sylvestre
Copy link
Contributor

Not a trivial change. Kudos!

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 0b397c4 into uutils:main Apr 7, 2025
73 of 74 checks passed
@sylvestre
Copy link
Contributor

well done!
looking forward to seeing missing code coverage again :)

@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
@sylvestre sylvestre mentioned this pull request Jun 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RenjiSann @sylvestre