CI: improve the intermittent ignore #7411
Merged
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
example that I am trying to fix |
|
GNU testsuite comparison: |
There was a problem hiding this comment.
PR Overview
This PR enhances the CI process by differentiating between intermittent and non-intermittent test failures while comparing test results against the main branch.
- In util/compare_gnu_result.py, a new check based on an environment variable determines if failing tests are all intermittent, thereby opting to not fail the build.
- In .github/workflows/GnuTests.yml, new logic is added to detect non-intermittent failures and update an environment variable to reflect this distinction, ensuring that only non-intermittent failures fail the build.
Reviewed Changes
| File | Description |
|---|---|
| util/compare_gnu_result.py | Added check for the ONLY_INTERMITTENT environment variable to control whether to exit with an error. |
| .github/workflows/GnuTests.yml | Updated CI workflow to conditionally set the ONLY_INTERMITTENT flag based on failure types. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
util/compare_gnu_result.py:48
- The 'sys.exit(1)' call appears to have inconsistent indentation compared to its sibling print statement in the else block. Please ensure it is aligned correctly to belong to the else clause.
sys.exit(1)
.github/workflows/GnuTests.yml:277
- [nitpick] The variable name 'have_non_intermittent_failures' could be made clearer. Consider renaming it to something like 'non_intermittent_failure_detected' for improved readability.
have_non_intermittent_failures="true"
cakebaker
reviewed
Mar 7, 2025
.github/workflows/GnuTests.yml
Outdated
| @@ -217,6 +217,9 @@ jobs: | |||
| run: | | |||
| ## Compare test failures VS reference | |||
| have_new_failures="" | |||
| ## Collect if we detect any non-intermittent failures | |||
| ## this will be used by util/compare_gnu_result.py | |||
| have_non_intermittent_failures="" | |||
There was a problem hiding this comment.
Currently have_non_intermittent_failures is identical to have_new_failures (the same value is assigned at the same places) and so either there is a bug somewhere or the variable is redundant.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.