printf: fix octal escape parsing #7431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i don't mind it
|
b966481 to
5326d19
Compare
|
Well it looks like my suggestions are incompatible with other dependencies of |
|
GNU testsuite comparison: |
5326d19 to
9c6d1fc
Compare
cakebaker
reviewed
Mar 11, 2025
| pub fn parse_escape_code(rest: &mut &[u8]) -> Result<EscapedChar, EscapeError> { | ||
| pub fn parse_escape_code( | ||
| rest: &mut &[u8], | ||
| zero_octal_parsing: Option<OctalParsing>, |
There was a problem hiding this comment.
I'm not sure about the Option here. None currently indicates that the default variant of OctalParsing should be used (and not that there is no OctalParsing). Maybe it makes sense to explicitly mark one of the OctalParsing variants as default and use OctalParsing::default() where None is currently used?
9c6d1fc to
2cbad60
Compare
Co-authored-by: aryal <141743392+aryalaadi@users.noreply.github.com>
2cbad60 to
bbca2ff
Compare
|
GNU testsuite comparison: |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refit of #7210 by @aryalaadi
I had some trouble rebasing so I just copied the changes manually to a new branch, so your name disappears from the commits. Sorry for that, I'll try to find a way to make you a co-author of these changes
Fixes #7202