fsext.rs: use correct type for fsid_t #7468
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2a0d58d changed this line from libc::fsid_t to nix::sys::statfs::fsid_t. The pull-request description at #3396 indicates that this was done in order to fix the android build, however I think it should compile for android without this change.
Inside the nix crate, fsid_t is defined as:
This all works as long as the libc version used by nix is the same than the libc version used by coreutils.
This breaks when using a local libc version (for local debugging, I was modifying libc and testing changes), because self.f_fsid which is of type libc::fsid_t (local version of libc) is then incompatible with nix::sys::statfs::fsid_t (upstream version of libc).
I was getting this error: