Add test to ensure arch output is not empty #7523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test ensures that the output of the arch command is non-empty, which is a minimal expectation across all supported architectures. This helps avoid regressions or edge cases where the command might unexpectedly return an empty string on unsupported or misconfigured platforms.
|
GNU testsuite comparison: |
cakebaker
reviewed
Mar 22, 2025
|
Can you please run |
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
|
Just formatted with cargo fmt as requested. |
|
GNU testsuite comparison: |
|
Thanks for your PR! |
nickorlow
pushed a commit
to nickorlow/coreutils
that referenced
this pull request
Jul 17, 2025
* Add test to ensure arch output is not empty This test ensures that the output of the arch command is non-empty, which is a minimal expectation across all supported architectures. This helps avoid regressions or edge cases where the command might unexpectedly return an empty string on unsupported or misconfigured platforms. * Update tests/by-util/test_arch.rs Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> * Apply cargo fmt formatting --------- Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test ensures that the output of the arch command is non-empty, which is a minimal expectation across all supported architectures.
This helps avoid regressions or edge cases where the command might unexpectedly return an empty string on unsupported or misconfigured platforms.