Skip to content

refactor: Add thiserror to df #7545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 2, 2025
Merged

refactor: Add thiserror to df #7545

merged 6 commits into from
Apr 2, 2025

Conversation

kiran-4444
Copy link
Contributor

@kiran-4444 kiran-4444 commented Mar 23, 2025 •
edited by cakebaker
Loading

This PR adds thiserror to df.

closes #7537

@sylvestre
Copy link
Contributor

You have some job failure
and it seems that you are also fixing #7536 (this is fine but please mention it in the commit msg)

sylvestre
sylvestre reviewed Mar 23, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/df/df-output. tests/df/df-output is passing on 'main'. Maybe you have to rebase?

@kiran-4444
Copy link
Contributor Author

I tried fixing the tests. Everything seems to work but I couldn't figure out how to make:

FilesystemTypeBothSelectedAndExcluded(Vec<String>),

compatible with thiserror. Can someone help me out please?

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@kiran-4444
Copy link
Contributor Author

I removed the changes related to #7536 cause I couldn't understand how to use thiserror on FilesystemTypeBothSelectedAndExcluded.

sylvestre
sylvestre reviewed Mar 31, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@kiran-4444
Copy link
Contributor Author

I'll tackle #7536 in a separate PR.

@cakebaker cakebaker merged commit 3a0b43b into uutils:main Apr 2, 2025
68 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR!

@kiran-4444 kiran-4444 deleted the refactor/use-thiserror-df branch April 2, 2025 10:31
@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
nickorlow pushed a commit to nickorlow/coreutils that referenced this pull request Jul 17, 2025
@kiran-4444 @nickorlow
df: add thiserror (uutils#7545)
27555d6 
* refactor: Add thiserror to df

* fix: Try fixing tests

* refactor(df): Move `df` to `thiserror`

* chore(df): Add back comment

* chore: Refactor column.rs correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

df/DfError: move to use thiserror
3 participants
@kiran-4444 @sylvestre @cakebaker