Skip to content

Conversation

kaathewisegit
Copy link
Contributor

This is a part of my upgrade efforts to ensure that all Nushell downstream dependencies use unicode-width 0.2.0 to avoid duplicating all of the unicode tables in the binary.

This is a part of my upgrade efforts to ensure that all Nushell downstream
dependencies use `unicode-width` 0.2.0 to avoid duplicating all of the unicode
tables in the binary.
@cakebaker
Copy link
Contributor

Thanks for your PR, however, #7599 already upgraded os_display to 0.1.4.

@cakebaker cakebaker closed this Mar 28, 2025
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@kaathewisegit
Copy link
Contributor Author

Got it, thanks!

@cakebaker
Copy link
Contributor

We still have two versions of unicode-width in our Cargo.lock. If that's a problem for nushell, please let me know.

@kaathewisegit
Copy link
Contributor Author

Not yet, since Nushell doesn't depend on all of the uu crates. I'll open an issue/PR if anything changes, but for now it'll have to wait, because ratatui are currently doing their alpha releases for 0.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants