Skip to content

ls: fix strange --classify output #7612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ls: fix strange --classify output #7612

wants to merge 2 commits into from

Conversation

alirezafarghadani999
Copy link

FIX #6897

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/ls/stat-dtype. tests/ls/stat-dtype is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker changed the title fix strange --classify output ls: fix strange --classify output Mar 30, 2025
@tertsdiepraam
Copy link
Member

@sylvestre I think you introduced the tab feature. I think it's probably good to go back to 2 spaces until uutils/uutils-term-grid#46 lands. Do you agree?

tertsdiepraam
tertsdiepraam requested changes Apr 8, 2025
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was of course a bit to quick to approve, because this does need some tests to be adapted. Could you change the tests that are failing on CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ls: strange --classify output
2 participants
@alirezafarghadani999 @tertsdiepraam