-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
tail: Performance improvements #7643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GNU testsuite comparison:
|
f2a4808
to
47f5ddd
Compare
GNU testsuite comparison:
|
Ok(0) => { | ||
return Ok(total); | ||
} | ||
let mut count = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know the original code doesn't have any comment but maybe it is the opportunity to explain what it is doing now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates done. Thanks.
Improve performance of `tail` utility. Tail now uses performance-optimized memchr APIs when searching through a file for delimiters.
47f5ddd
to
b264457
Compare
GNU testsuite comparison:
|
Reasonable performance improvements for
tail
command. Benchmarks...