uucore: Move extendedbigdecimal and parsers to 2 separate features #7647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be needed later on so that we can split format and parse features.
|
GNU testsuite comparison: |
This will eventually be needed as we'll want parse_time to call into num_parser, which was previously contained in format feature.
6ba05a3 to
6243dd5
Compare
|
GNU testsuite comparison: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Hopefully) mechanical change, moving files around so that parsing code becomes a feature in uucore. This is a no-op, but will be required so that we can update
parse_timeto parse the time duration from a ExtendedBigDecimal, which will help fix #7475 (see #7648 for draft PR that stacks on top of this).uucore: Move parser to a feature
This will eventually be needed as we'll want parse_time to
call into num_parser, which was previously contained in format
feature.
uucore: Move extendedbigdecimal to its own feature
This will be needed later on so that we can split format and
parse features.