cp: fix update prompting #7668
Merged
cp: fix update prompting #7668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is newer, to skip copying
|
GNU testsuite comparison: |
|
Can you please run the tests? Your solution currently breaks two tests. |
|
sorry about that, not sure how i missed that. |
|
GNU testsuite comparison: |
nice! two things:
|
- adjusted conditions to satisfy clippy
|
GNU testsuite comparison: |
|
Apologizes for the failed checks still, could I get some help/clarification on the errors I'm seeing?
Are these failed tests actionable for me? If so, are there starting steps I should take? The patience and feedback is much appreciated! |
|
@hz2 no, those failing tests are unrelated to your PR. |
cakebaker
reviewed
Apr 10, 2025
cakebaker
reviewed
Apr 10, 2025
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
|
@cakebaker much cleaner, thank you! |
|
GNU testsuite comparison: |
|
Thanks for your PR :) |
nickorlow
pushed a commit
to nickorlow/coreutils
that referenced
this pull request
Jul 17, 2025
* added logic to check if we are updating the file and the destination is newer, to skip copying * corrected logic to handle cp update * - added test case that mocks the issue described in uutils#7660 - adjusted conditions to satisfy clippy * typo * Update src/uu/cp/src/cp.rs Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> * Update tests/by-util/test_cp.rs Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com> --------- Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy_sourceafter resolving src and dst to comparetimestamps
Fixes #7660