chore: address a few clippy lints that break API #7697
Conversation
|
GNU testsuite comparison: |
|
thx @tertsdiepraam - do note that you already have these pedantic lints enabled in the main Cargo.toml -- the reason they were not fixed was because Clippy skips many lints which are "public" - but since uutils goal does not seem to be primarily a library, but rather an executable, it makes no sense to skip so many clippy lints just because the items happen to be exported. Thus, I would highly recommend enabling it in the Clippy.toml to keep the codebase consistent |
|
I kind of agree, but there is a library component to uutils, which is used by nushell for example. |
|
thx, didn't know about that. The issue still remains - if you do not enable it in Clippy.toml, new PRs will not be checked by Clippy if they are public - potentially missing some important notifications. The issue with nushell should be solved with the semver checker - which would flag these changes to go into the breaking changes release. |
|
Since every release is currently breaking, I guess it's more of a thing of not changing things too much arbitrarily. But for a proper long term solution, you are right of course! |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
* Disabled `avoid-breaking-exported-api` and sorted items in Clippy.toml * Renamed `BSD` -> `Bsd`, `SYSV` -> `SysV`, and `CRC` -> `Crc` to match Rust naming rules * Renamed items in `BackupMode` and `UpdateMode` because they repeated the same word in every item - making it redundant and harder to read
|
GNU testsuite comparison: |
avoid-breaking-exported-apiand sorted items in Clippy.tomlBSD->Bsd,SYSV->SysV, andCRC->Crcto match Rust naming rulesBackupModeandUpdateModebecause they repeated the same word in every item - making it redundant and harder to read