Skip to content

feat: optimize dd parsing, bugfix #7704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2025
Merged

feat: optimize dd parsing, bugfix #7704

merged 2 commits into from
Apr 14, 2025

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 8, 2025

  • Simplify param parsing in dd by using iterator instead of a slice
  • Fix two unit tests that appear to have a minor bug (?) - adding iflag=<...> instead of oflag=<...> during testing

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/cp-i. tests/cp/cp-i is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/cp/cp-i. tests/cp/cp-i is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@nyurik nyurik force-pushed the optimize-dd branch 2 times, most recently from 67a2db6 to 6c0e600 Compare April 13, 2025 04:20
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

nyurik added 2 commits April 14, 2025 14:01
@nyurik
feat: optimize dd parsing, bugfix
db6a7a3 
* Simplify param parsing in `dd` by using iterator instead of a slice
* Fix two unit tests that appear to have a minor bug (?) - adding `iflag=<...>` instead of `oflag=<...>` during testing
@nyurik
revert some merge issues
90f45b5
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

tertsdiepraam
tertsdiepraam approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like how the refactor solved the iflag/oflag confusion automatically.

@tertsdiepraam tertsdiepraam merged commit c1d2a07 into uutils:main Apr 14, 2025
69 checks passed
@nyurik nyurik deleted the optimize-dd branch April 14, 2025 20:00
@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyurik @tertsdiepraam