Enable and fix unused_qualifications lint
#7715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not convinced that it improves code readability. I think that for some cases, it decreases it |
6c1be4d to
1e7411f
Compare
|
@sylvestre I agree that it some cases it makes things less readable -- but in that case the more explicit namespaced identifier should be used throughout the file. Otherwise you have a confusing situation - the same ident is used with and without the namespace just a few lines apart. This lint does not force shorter idents, it forces them to be consistently used per file. |
|
GNU testsuite comparison: |
13e4918 to
28f5b33
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Apr 10, 2025
src/uu/chcon/src/fts.rs
Outdated
| @@ -16,9 +16,9 @@ use crate::os_str_to_c_string; | |||
|
|
|||
| #[derive(Debug)] | |||
| pub(crate) struct FTS { | |||
| fts: ptr::NonNull<fts_sys::FTS>, | |||
There was a problem hiding this comment.
@sylvestre you had a few NonNull directly used - i updated those
Improve code readability
39f893a to
e796718
Compare
e796718 to
76b1b68
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve code readability. What's even more important is that the same identifier is used identically everywhere in one file - i.e.
chrono::DateTimewould not be used with a fully-qualified name in one place, but with justDateTimein another.