cp -P hardlink-to-symlink hardlink-to-same-symlink should no-op #7753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
BenWiederhake
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7729 (comment)
Recap:
It looks like GNU detects that the hardlinks are the same and simply no-ops (I did an
straceand all it's doing isstat-ing each file and exiting). There's similar logic inuutils, but it's currently conditioned on the backup option. I think this is unnecessary since if source and dest are hardlinks to the same file, then no actual copy should be necessary. Let me know if I may be missing something though; there are an awful lot of obscure edge cases though (luckily there are many unit tests for them).