du: already passes GNU test in spirit, adjust test #7754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
CI failure |
|
excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts a GNU test to accept our phrasing of the error message.
I was looking at low-hanging fruit on the table, and dived straight into
du/move-dir-while-traversing.This GNU test exists to ward against a regression: an old GNU coreutils version used to contain a bug that triggered an assertion failure. The test's intention is to make sure that
dufails not due to an assertion error (thus not producing any information, or corrupt output), but rather due to the correct reason (files vanishing). In particular, we simply emit a slightly different error message than GNU, and that's why we technically didn't pass that test.However, since we pass the spirit of the test, I think it is appropriate to adapt the test to check for our phrasing of the error message.
While I was at it, I refreshed one of the other quilt patches, since the line numbers changed. I made sure to use GNU coreutils at git tag v9.7. I ignored two other diffs introduced by
quilt refresh, since I'm not convinced they are correct.