yes: Remove usage of vmsplice #7770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue uutils#7625 Remove the usage of vmsplice from `yes` utility since it can cause errors.
|
GNU testsuite comparison: |
|
Are we not regressing in term of features with this PR ? |
In the issue report the request was to remove the usage of |
|
I think it would be a regression in terms of speed, but not in features. I just commented in that thread. |
yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #7625
Remove the usage of vmsplice from
yesutility since it can cause errors.I think this is what is being asked for. I've asked for confirmation on the original thread that this is indeed the request.