Skip to content

uucore: handle situation using numberic username #7788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

uucore: handle situation using numberic username #7788

wants to merge 2 commits into from
+46 −14

Conversation

zhw2101024
Copy link
Contributor

@zhw2101024 zhw2101024 commented Apr 19, 2025 •
edited by cakebaker
Loading

Fixes #7787

@sylvestre
Copy link
Contributor

Could you please add a test to make sure we don't regress in the future?
Thanks

@zhw2101024
Copy link
Contributor Author

Could you please add a test to make sure we don't regress in the future? Thanks

Sure, i'll do this soon.

@zhw2101024
Copy link
Contributor Author

Could you please add a test to make sure we don't regress in the future? Thanks

The test will need to add a temporary user, thus requires root permission.
Need some suggestions here.

@zhw2101024 zhw2101024 force-pushed the fix_numberic_username branch from c31e281 to c4c87c7 Compare April 20, 2025 05:13
@zhw2101024
Copy link
Contributor Author

@sylvestre Added a test which requires user with username 200 on the build machine and the CI environment.
Hope this is acceptable.

@zhw2101024 zhw2101024 force-pushed the fix_numberic_username branch 3 times, most recently from 6469bb9 to eef7f80 Compare April 20, 2025 06:05
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the fix_numberic_username branch 4 times, most recently from 98feb08 to 6a32616 Compare April 21, 2025 05:44
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 mentioned this pull request Apr 22, 2025
Closed
@zhw2101024 zhw2101024 force-pushed the fix_numberic_username branch 6 times, most recently from e900b2b to b598415 Compare April 26, 2025 16:31
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the fix_numberic_username branch from b598415 to 0626446 Compare April 28, 2025 03:22
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

id: handle numberic username incorrectly
2 participants
@zhw2101024 @sylvestre