Skip to content

fix the install_root_combined test failure when there's no user whth uid 2 #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix the install_root_combined test failure when there's no user whth uid 2 #7789

wants to merge 2 commits into from

Conversation

zhw2101024
Copy link
Contributor

No description provided.

@sylvestre
Copy link
Contributor

Could you please add a test to make sure we don't regress? Thanks

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 2 times, most recently from fa60b65 to 65d1bb6 Compare April 20, 2025 05:51
@zhw2101024
Copy link
Contributor Author

Could you please add a test to make sure we don't regress? Thanks

Finished the test.

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 65d1bb6 to f87aa34 Compare April 20, 2025 06:03
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 3 times, most recently from 961eec9 to 2dd5646 Compare April 21, 2025 05:54
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 2dd5646 to 6d1e62c Compare April 21, 2025 09:41
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/tee. tests/misc/tee is passing on 'main'. Maybe you have to rebase?

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 6d1e62c to 76477ee Compare April 21, 2025 13:50
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@zhw2101024 zhw2101024 mentioned this pull request Apr 22, 2025
Closed
@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 76477ee to 33830bb Compare April 27, 2025 06:48
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre force-pushed the test_install_root_combined branch from 33830bb to 054dc17 Compare April 27, 2025 21:54
@sylvestre
Copy link
Contributor

many jobs are failing

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/empty-inacc is no longer failing!

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 054dc17 to dde3ee9 Compare April 28, 2025 03:31
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@zhw2101024
Copy link
Contributor Author

many jobs are failing

Caused by some rebase issues, fixed it now. By the way, the test in this PR need to ensure that there's no user with userid 500 on the system, maybe I can modify the userid in the prepare stage of CICD runners?

@jtracey
Copy link
Contributor

jtracey commented Apr 29, 2025

I don't think you need to configure the system, you can just avoid hardcoding 500 and instead use the first UID not in /etc/passwd.

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from dde3ee9 to ee47432 Compare April 30, 2025 13:52
@zhw2101024
Copy link
Contributor Author

zhw2101024 commented Apr 30, 2025 •
edited
Loading

I don't think you need to configure the system, you can just avoid hardcoding 500 and instead use the first UID not in /etc/passwd.

I'm using a long script to get a uid not in /etc/passwd, so adding subprocess to use the Exec::shell method.
cat /etc/passwd|cut -d ':' -f 3|grep '^1...$'|sort -n|tail -n 1|awk '{print $1+1}'

@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 3 times, most recently from dd77eab to 74b9db7 Compare April 30, 2025 14:03
@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch 4 times, most recently from 88d46bb to 1a5d2a4 Compare April 30, 2025 14:52
@zhw2101024 zhw2101024 force-pushed the test_install_root_combined branch from 1a5d2a4 to 93fbf63 Compare April 30, 2025 15:13
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhw2101024 @sylvestre @jtracey