uucore: num_parser: Operate on slices, instead of iterator #7790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially after splitting the `parse` function in multiple chunks, this makes the code a bit easier to read, despite the fact that `parse` is still inherently a complex function.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially after splitting the
parsefunction in multiple chunks, this makes the code a bit easier to read, despite the fact thatparseis still inherently a complex function.@tertsdiepraam FYI, I think I like it better now, using slices consistently instead of a mix of slices and iterators. And if I understand correctly how slices work, this should be mostly equivalent, performance wise.
@Qelxiros FYI too, some small changes to stuff you touched (lifetimes mostly, carving out suffix parsing to a common function)