Skip to content

shred: correctly print zero-byte pass in verbose mode #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

shred: correctly print zero-byte pass in verbose mode #7800

merged 2 commits into from
Apr 21, 2025

Conversation

BenWiederhake
Copy link
Collaborator

Fixes #7798.

Before:

$ cargo run -q shred -v -n100 foo
<SNIP>
shred: foo: pass 11/100 (b6db6d)...
shred: foo: pass 12/100 (ffffff)...
shred: foo: pass 13/100 (222222)...
shred: foo: pass 14/100 (222222)...
shred: foo: pass 15/100 (000)...
shred: foo: pass 16/100 (999999)...
<SNIP>

After:

$ cargo run -q shred -v -n100 foo
<SNIP>
shred: foo: pass 34/100 (random)...
shred: foo: pass 35/100 (6db6db)...
shred: foo: pass 36/100 (000000)...
shred: foo: pass 37/100 (db6db6)...
shred: foo: pass 38/100 (888888)...
<SNIP>

@BenWiederhake BenWiederhake force-pushed the dev-shred-verbose-single-zero branch from 8b99d80 to 98d120f Compare April 20, 2025 16:58
@BenWiederhake
Copy link
Collaborator Author

(Change in last push: Fixed a typo in the test's expected output.)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit d7d0f9d into uutils:main Apr 21, 2025
70 checks passed
@cakebaker
Copy link
Contributor

Thanks!

@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
nickorlow pushed a commit to nickorlow/coreutils that referenced this pull request Jul 17, 2025
@BenWiederhake @sylvestre @nickorlow
shred: correctly print zero-byte pass in verbose mode (uutils#7800)
431d90d 
Fixes uutils#7798.

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shred: malformed verbose output on "000" pass
3 participants
@BenWiederhake @cakebaker @sylvestre