shred: fix random passes* #7822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 23, 2025
tests/by-util/test_shred.rs
Outdated
Comment on lines
14
to
15
| "000000", "ffffff", "555555", "aaaaaa", "249249", "492492", "6db6db", "924924", "b6db6d", | ||
| "111111", "222222", "333333", "444444", "555555", "666666", "777777", "888888", "999999", |
There was a problem hiding this comment.
I think 555555 should only appear once. And the pattern db6db6 is missing.
cakebaker
reviewed
Apr 23, 2025
tests/by-util/test_shred.rs
Outdated
Comment on lines
257
to
258
| at.touch(file); | ||
| at.append_bytes(file, &[0]); |
There was a problem hiding this comment.
A detail, you can simplify it to:
Suggested change
| at.touch(file); | |
| at.append_bytes(file, &[0]); | |
| at.write_bytes(file, &[0]); |
|
I mismanaged my branches, see #7830 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7809
On my system, the number of random passes (as determined by
shred -vn$x foo.txt |& grep random | wc -l) is not determined byx/10. While it's true that 25 is the tipping point at which all patterns are used, the pattern is unclear. I'll open a separate issue so I don't dump too much shell output here. For the purpose of this PR, I changed 3 + x/10 to (x/10).max(3) to get closer to GNU behavior.