Skip to content

install: fixes issue #7795 #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

install: fixes issue #7795 #7838

merged 1 commit into from
Apr 25, 2025

Conversation

zcg00
Copy link
Contributor

@zcg00 zcg00 commented Apr 25, 2025

Fixed issue with install deleting file when attempting to install to same file.

@cakebaker cakebaker linked an issue Apr 25, 2025 that may be closed by this pull request
install can accidently delete file #7795
Closed
@zcg00 zcg00 force-pushed the install_deletes_files branch from 6974d4e to b6dc1d3 Compare April 25, 2025 06:18
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/install/basic-1. tests/install/basic-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/create-leading. tests/install/create-leading is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-root. tests/install/install-C-root is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/strip-program. tests/install/strip-program is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ln/misc. tests/ln/misc is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/misc/xattr is now being skipped but was previously passing.

@cakebaker
Copy link
Contributor

cakebaker commented Apr 25, 2025 •
edited
Loading

GNU test failed: tests/install/basic-1. tests/install/basic-1 is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/create-leading. tests/install/create-leading is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/install-C-root. tests/install/install-C-root is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/install/strip-program. tests/install/strip-program is passing on 'main'. Maybe you have to rebase?

It looks like your changes break some GNU tests :|

Can you also please add a test to tests/by_util/test_install.rs?

@zcg00 zcg00 force-pushed the install_deletes_files branch 3 times, most recently from 3226212 to ddf89b5 Compare April 25, 2025 10:03
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@zcg00 zcg00 force-pushed the install_deletes_files branch from ddf89b5 to df2dc14 Compare April 25, 2025 10:47
@zcg00 zcg00 force-pushed the install_deletes_files branch from df2dc14 to 827d0fc Compare April 25, 2025 10:48
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker merged commit 0ec36be into uutils:main Apr 25, 2025
70 checks passed
@cakebaker
Copy link
Contributor

Thanks!

@zcg00 zcg00 deleted the install_deletes_files branch April 25, 2025 19:27
@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

install can accidently delete file
2 participants
@zcg00 @cakebaker