set_selinux_security_context should return an Error, not String #7845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b2f462 to
745d0c8
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
28ab28a to
e23f45f
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 26, 2025
cakebaker
reviewed
Apr 26, 2025
cakebaker
reviewed
Apr 26, 2025
|
GNU testsuite comparison: |
acf4129 to
1fa2ca2
Compare
|
GNU testsuite comparison: |
1fa2ca2 to
6b52212
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 28, 2025
cakebaker
reviewed
Apr 28, 2025
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 28, 2025
cakebaker
reviewed
Apr 28, 2025
Comment on lines
+278
to
+315
| SeLinuxError::SELinuxNotEnabled => assert!(true, "SELinux not supported"), | ||
| SeLinuxError::ContextRetrievalFailure(e) => { | ||
| println!("Context retrieval failure: {}", e); | ||
| assert!(true, "Context retrieval failure"); | ||
| } | ||
| SeLinuxError::ContextConversionFailure(ctx, e) => { | ||
| println!("Context conversion failure for '{}': {}", ctx, e); | ||
| assert!(true, "Context conversion failure"); | ||
| } | ||
| SeLinuxError::ContextSetFailure(ctx, e) => { | ||
| println!("Context set failure for '{}': {}", ctx, e); | ||
| assert!(true, "Context set failure"); | ||
| } |
There was a problem hiding this comment.
What's the purpose of the assert!(true)? They will always pass.
cakebaker
reviewed
Apr 28, 2025
Comment on lines
211
to
213
| match err { | ||
| SeLinuxError::SELinuxNotEnabled => { | ||
| assert!(true, "SELinux is not enabled, which is a valid error case"); | ||
| } | ||
| _ => { | ||
| println!("Error setting context: {}", err); | ||
| // Only assert for cases where we expect specific error messages | ||
| // other errors can happen depending on the SELinux configuration | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not sure about this entire test function (test_selinux_context_setting) as it will (almost) never fail, only when something goes wrong with creating a temp file.
+ fix comments from review
8dfef16 to
4d7aeca
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.