chcon: link to libfts on musl targets #7863
Open
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a build failure on aarch64-unknown-linux-musl. On musl‐based targets the fts API is not provided by libc but by a separate libfts library. * src/uu/chcon/build.rs Add a build script (`build.rs`) that detects when `CARGO_CFG_TARGET_OS=linux` && `CARGO_CFG_TARGET_ENV=musl` and emits `rustc-link-lib=fts`, so that `uu-chcon` can link successfully. * src/uu/chcon/src/fts.rs In the glibc version of the header, `level` is `short`, under musl it's `int`; likewise, `pathlen` is `unsigned` on musl but signed on glibc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a build failure on aarch64-unknown-linux-musl.
On musl‐based targets the fts API is not provided by libc but by a separate libfts library.
src/uu/chcon/build.rsAdd a build script (
build.rs) that detects whenCARGO_CFG_TARGET_OS=linux&&CARGO_CFG_TARGET_ENV=musland emitsrustc-link-lib=fts, so thatuu_chconcan link successfully.src/uu/chcon/src/fts.rsIn the glibc version of the header,
levelisshort, under musl it'sint; likewise,pathlenisunsignedon musl but signed on glibc.Note
To test this, I build as:
RUSTFLAGS='-Ctarget-feature=-crt-static' makein Alpine Linux.