Skip to content

uptime: refactor uumain #7892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

uptime: refactor uumain #7892

merged 3 commits into from
May 9, 2025

Conversation

cakebaker
Copy link
Contributor

This PR refactors uumain. It applies the following changes:

  • use clap to handle the "too many paths provided" error case
  • remove unix block and make a single var platform-specific instead
  • split default_uptime into two functions

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 45b0c39 into uutils:main May 9, 2025
70 checks passed
@cakebaker cakebaker deleted the uptime_refactor_uumain branch May 10, 2025 04:56
@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre