csplit: don't add a newline if the file doesn't end with one #7901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
bcd7dda to
d782cc4
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
May 8, 2025
|
GNU testsuite comparison: |
cakebaker
reviewed
May 8, 2025
cakebaker
reviewed
May 8, 2025
|
GNU testsuite comparison: |
|
Thanks! |
RenjiSann
pushed a commit
to RenjiSann/coreutils
that referenced
this pull request
May 23, 2025
…7901) * csplit: don't add a newline if the file doesn't end with one * refactor test * refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7126
BufRead::linesis inherently lossy in that it is impossible to know whether a line ended due to a newline or EOF. In this PR, I replaced it with a custom iterator usingBufRead::read_untilto keep track of the line endings manually.