.cargo/config.toml: set CFLAGS='-std=gnu17'
#7944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b6802e to
e3c0e20
Compare
|
GNU testsuite comparison: |
to make onig compile with GCC 15, which by default uses a newer C standard (C23)
e3c0e20 to
992e162
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
May 20, 2025
| [target.x86_64-unknown-redox] | ||
| linker = "x86_64-unknown-redox-gcc" | ||
|
|
||
| [env] | ||
| PROJECT_NAME_FOR_VERSION_STRING = "uutils coreutils" | ||
| # TODO remove when there is an onig version > 6.4.0, https://github.com/rust-onig/rust-onig/issues/196 | ||
| CFLAGS='-std=gnu17' |
There was a problem hiding this comment.
this is going to be passed to all C code
it isn't a big deal but i still would like to mention it
There was a problem hiding this comment.
What do you mean with "i still would like to see it"?
There was a problem hiding this comment.
Ah, ok :) If it's an issue, we could use onig from github.
|
@cakebaker https://github.com/uutils/coreutils/actions/runs/15131823978/job/42534881943?pr=7931 it broke the build here warning: onig_sys@69.8.1: x86_64-linux-gnu-gcc: error: unrecognized command line option '-std=gnu17' |
cakebaker
added a commit
to cakebaker/coreutils
that referenced
this pull request
May 20, 2025
with "unrecognized command line option '-std=gnu17'"
Merged
sylvestre
added a commit
that referenced
this pull request
May 20, 2025
Closed
RenjiSann
pushed a commit
to RenjiSann/coreutils
that referenced
this pull request
May 23, 2025
with "unrecognized command line option '-std=gnu17'"
willshuttleworth
pushed a commit
to willshuttleworth/coreutils
that referenced
this pull request
May 24, 2025
with "unrecognized command line option '-std=gnu17'"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
CFLAGS='-std=gnu17'in order to makeonigcompile with GCC 15, which by default uses a newer C standard (C23).It temporarily fixes #7904 until there is a new
onigrelease. An alternative approach would be to change the dependency line foroniginCargo.tomlas suggested in #7904 (comment)