Skip to content

ci: run cargo fmt --check in fuzz folder #7958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

ci: run cargo fmt --check in fuzz folder #7958

merged 1 commit into from
May 19, 2025

Conversation

cakebaker
Copy link
Contributor

This PR runs cargo fmt --check in the fuzz folder. It's related to #7949.

@cakebaker cakebaker marked this pull request as draft May 19, 2025 12:12
@cakebaker cakebaker force-pushed the ci_run_fmt_on_fuzz branch from 29a89a8 to 9fec8c0 Compare May 19, 2025 12:14
@cakebaker cakebaker marked this pull request as ready for review May 19, 2025 12:16
@cakebaker
Copy link
Contributor Author

The job fails as expected:

Diff in /home/runner/work/coreutils/coreutils/fuzz/fuzz_targets/fuzz_test.rs:146:
                 let random_str = generate_random_string(rng.random_range(1..=10));
                 let random_str2 = generate_random_string(rng.random_range(1..=10));
 
-                arg.push_str(&format!(
-                    "{random_str} {} {random_str2}",
-                    test_arg.arg,
-                ));
+                arg.push_str(&format!("{random_str} {} {random_str2}", test_arg.arg,));

@cakebaker cakebaker marked this pull request as draft May 19, 2025 12:25
@cakebaker cakebaker marked this pull request as ready for review May 19, 2025 12:26
@cakebaker cakebaker force-pushed the ci_run_fmt_on_fuzz branch from 9fec8c0 to 04ca61d Compare May 19, 2025 12:38
@sylvestre sylvestre merged commit 9858c20 into uutils:main May 19, 2025
70 checks passed
@cakebaker cakebaker deleted the ci_run_fmt_on_fuzz branch May 19, 2025 12:57
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre