Skip to content

ci: install libselinux1-dev for coverage job #7959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

ci: install libselinux1-dev for coverage job #7959

merged 1 commit into from
May 20, 2025

Conversation

cakebaker
Copy link
Contributor

I noticed the following error in the Code Coverage job (see, for example, https://github.com/uutils/coreutils/actions/runs/15113187214/job/42477260722#step:9:5458):

thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/selinux-sys-0.6.14/build.rs:258:10:
  selinux-sys: Failed to find 'selinux/selinux.h'. Please make sure the C header files of libselinux are installed and accessible: Kind(NotFound)

This PR (hopefully) fixes this issue by installing libselinux1-dev.

@cakebaker
Copy link
Contributor Author

While the original error is gone, some tests fail now :| But I guess that's something for a different PR...

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cp/no-ctx is no longer failing!

@sylvestre
Copy link
Contributor

Congrats! The gnu test tests/cp/no-ctx is no longer failing!

at least, i see it here :)

@sylvestre
Copy link
Contributor

@cakebaker you still want to land it, right?

@cakebaker
Copy link
Contributor Author

@sylvestre yes, please :) The two issues are unrelated and I think it makes sense to fix the new issue in a different PR.

@sylvestre sylvestre merged commit 263ba63 into uutils:main May 20, 2025
70 checks passed
@cakebaker cakebaker deleted the ci_install_libselinux1_dev branch May 20, 2025 08:07
@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre