Skip to content

i18n: further work, expr support #8292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

i18n: further work, expr support #8292

wants to merge 5 commits into from

Conversation

RenjiSann
Copy link
Collaborator

Replaces #7986

@RenjiSann RenjiSann mentioned this pull request Jun 30, 2025
Closed
@RenjiSann RenjiSann force-pushed the collating branch 2 times, most recently from 26a0eee to 644ea84 Compare June 30, 2025 20:46
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/fmt/goal-option is no longer failing!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

sylvestre
sylvestre reviewed Jul 1, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

sylvestre
sylvestre reviewed Jul 1, 2025
View reviewed changes
src/uucore/src/lib/features/i18n/mod.rs
let mut split = locale_var_str.split(&['.', '@']);

if let Some(simple) = split.next() {
let bcp47 = simple.replace("_", "-");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a comment explaining what means bcp47 :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RenjiSann @sylvestre