Skip to content

Add devcontainer setup and small related fixes #8486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinkunkel2
Copy link
Contributor

@martinkunkel2 martinkunkel2 commented Aug 16, 2025

  • Added devcontainer configuration based on Ubuntu 24.04
  • Added GitHub Actions workflow for devcontainer testing
  • Update cSpell configuration to ingore spelling in devcontainer configs
  • Update pre-commit hooks to exclude cSpell.json because pre-commit fails for that file due to json with comments format
  • Fix filename for cSpell config in vscode settings
  • Two tests in test_dd.rs are now skipped if /dev/sda1 is not available, which is the case in devcontainer
  • Update check for existing gnu clone in build-gnu.sh, not checking the existence of the directory but the presence of the .git directory. This allows us to have the directly as a volume mount in devcontainer
  • Remove temporary file g after use in build-gnu.sh

Note: the github codespaces feature will also use the devcontainer configuration and developers can start a codespace to avoid any local installation, in case they wish to do so, e.g. for small fixes:
Screenshot 2025-08-16 121414

Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

- Added devcontainer configuration based on Ubuntu 24.04
- Added GitHub Actions workflow for devcontainer testing
- Update cSpell configuration to ingore spelling in devcontainer configs
- Update pre-commit hooks to exclude cSpell.json because pre-commit
  fails for that file due to json with comments format
- Fix filename for cSpell config in vscode settings
- Two tests in `test_dd.rs` are now skipped if /dev/sda1 is not
  available, which is the case in devcontainer
- Update check for existing gnu clone in build-gnu.sh, not checking the
  existence of the directory but the presence of the .git directory.
  This allows us to have the directly as a volume mount in devcontainer
- Remove temporary file `g` after use in build-gnu.sh
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant