Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: uutils/parse_datetime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.1
Choose a base ref
...
head repository: uutils/parse_datetime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.4.0
Choose a head ref
  • 15 commits
  • 11 files changed
  • 4 contributors

Commits on Jun 3, 2023

  1. add datetime parser

    Add a relaxed datetime parser. This datetime parser functions by using `chrono`s
    own parsing utilities and a try/succeed approach to parsing.
    
    This implementation of the datetime parser has some drawbacks and some
    positives. On the positive side:
    - it was easy to implement
    - it is easy to add more datetime formats to
    
    In order to add additionally supported formats, a developer can add the
    required format string to the `format` mod in `parse_datetime.rs`, and
    then add it as a potential format to the relevant `fmts` vec.
    
    On the negative:
    - It is not easily customiseable beyond the supported `chrono` parsing
      formats. E.g., `chrono` does not currently support parsing offsets
      without trailing zeros. `from_str("UTC+1")` should return a valid response
      but `chrono` fails to parse this.
    - Because it is an attempt driven parser, it is likely not that
      performant. I have not done any performance testing as part of this
    change, but I would expect a custom parser to perform much better.
    Benjscho committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    e53aabd View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Fixes for comments

    Benjscho committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c177117 View commit details
    Browse the repository at this point in the history
  2. typo fix

    Benjscho committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    8d797fc View commit details
    Browse the repository at this point in the history
  3. Update src/parse_datetime.rs

    Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
    Benjscho and sylvestre authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    29e7a5c View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Update README

    Update the README and add a test module to parse_datetime for any
    examples presented in the README.
    Benjscho committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    bc33770 View commit details
    Browse the repository at this point in the history
  2. cargo fmt

    Benjscho committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    7ee33d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Merge pull request #12 from Benjscho/main

    add datetime parser
    sylvestre authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    e503de7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc508c4 View commit details
    Browse the repository at this point in the history
  3. run the fuzzers in the CI

    sylvestre committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    22bdd8f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    80f8fdf View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Merge pull request #21 from sylvestre/fuzz

    Also fuzz fuzz_parse_datetime_from_str for a minute
    sylvestre authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    83e1431 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    673d5b6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #22 from sylvestre/rename

    rename from humantime_to_duration to parse_datetime
    sylvestre authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    c1a2bef View commit details
    Browse the repository at this point in the history
  3. document the old name

    sylvestre committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    7ab1ad2 View commit details
    Browse the repository at this point in the history
  4. Release version 0.4.0

    sylvestre committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    bed2d16 View commit details
    Browse the repository at this point in the history
Loading