Skip to content

rename from humantime_to_duration to parse_datetime #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

sylvestre
Copy link
Contributor

No description provided.

@sylvestre
Copy link
Contributor Author

@Benjscho WDYT?

Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is better and we better change it before someone starts using it :)

@sylvestre sylvestre merged commit c1a2bef into uutils:main Jun 9, 2023
@sylvestre sylvestre deleted the rename branch June 9, 2023 11:41
@Benjscho
Copy link
Contributor

Benjscho commented Jun 9, 2023

Yup the rename is better! Need to set aside some time for a reorg PR

@fritzmark
Copy link

I fear this destroyed the auto update. See my comment.
Also installation fails now:

╰─> cargo uninstall coreutils
    Removing C:\Users\xxxxx\.cargo\bin\coreutils.exe
╰─> cargo install coreutils
    Updating crates.io index
  Installing coreutils v0.0.19
    Updating crates.io index
error: failed to compile `coreutils v0.0.19`, intermediate artifacts can be found at `C:\Users\xxxxx\AppData\Local\Temp\cargo-installlPgsr5`

Caused by:
  no matching package named `humantime_to_duration` found
  location searched: registry `crates-io`
  required by package `uu_date v0.0.19`
      ... which satisfies dependency `date = "^0.0.19"` of package `coreutils v0.0.19`

@sylvestre
Copy link
Contributor Author

I don't think it is related. I think it is because I yanked the crate.
I revert it, could you please try again?
https://crates.io/crates/humantime_to_duration/0.3.1

@fritzmark
Copy link

Yeah that fixed it:

   Installed package `coreutils v0.0.19` (executable `coreutils.exe`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants