Skip to content

Port the crate to use chrono instead of time #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2023
Merged

Port the crate to use chrono instead of time #11

merged 3 commits into from
Jun 3, 2023

Conversation

sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Jun 3, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Jun 3, 2023 •
edited
Loading

Codecov Report

Merging #11 (6ba55a0) into main (f1a15ab) will decrease coverage by 34.07%.
The diff coverage is 64.00%.

❗ Current head 6ba55a0 differs from pull request most recent head 1d78cc5. Consider uploading reports for the commit 1d78cc5 to get more accurate results

@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
- Coverage   75.74%   41.68%   -34.07%     
===========================================
  Files           2        2               
  Lines         301      511      +210     
  Branches       61      103       +42     
===========================================
- Hits          228      213       -15     
- Misses         31      256      +225     
  Partials       42       42
Flag Coverage Δ
macos_latest 41.68% <64.00%> (-34.07%) ⬇️
ubuntu_latest 41.68% <64.00%> (-34.07%) ⬇️
windows_latest 42.68% <66.66%> (-33.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib.rs 30.12% <52.63%> (-40.35%) ⬇️
tests/simple.rs 85.84% <100.00%> (+0.66%) ⬆️

cakebaker
cakebaker reviewed Jun 3, 2023
View reviewed changes
cakebaker
cakebaker reviewed Jun 3, 2023
View reviewed changes
@sylvestre sylvestre merged commit a60f1d8 into uutils:main Jun 3, 2023
@sylvestre sylvestre deleted the chrono branch June 3, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker approved these changes

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvestre @cakebaker