Skip to content

Upgrade winnow to 0.7.10 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Upgrade winnow to 0.7.10 #141

merged 1 commit into from
May 19, 2025

Conversation

yuankunzhang
Copy link
Contributor

@yuankunzhang yuankunzhang commented May 11, 2025

Closes #140.

Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly, but I'm concerned about the error context. Can we get that back somehow?

@yuankunzhang
Copy link
Contributor Author

@tertsdiepraam please review this PR :)

Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

)));
return Err(ErrMode::Backtrack(ctx_err));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this is marked with backtrack, but it already was so let's leave it.

@tertsdiepraam tertsdiepraam merged commit cc7c143 into uutils:main May 19, 2025
14 checks passed
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (852e49e) to head (bea8ec2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #141   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate winnow from 0.5.x to 0.7.x
2 participants