Skip to content

fix: check whether the parsed time contains timezone #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

fix: check whether the parsed time contains timezone #150

merged 1 commit into from
Jun 14, 2025

Conversation

yuankunzhang
Copy link
Contributor

Closes #147.

Why m1y was accepted: m1y was parsed as an offset m and a time 1y; the time 1y contains two elements: the hour 1 and the offset y. So the problem here is the duplication of offsets.

cc @drinkcat

@yuankunzhang yuankunzhang changed the title fix: check whether the parsed time contain timezone fix: check whether the parsed time contains timezone May 27, 2025
@drinkcat
Copy link
Contributor

Thanks! LGTM. Found this easier to review by looking at the individual commits.

@sylvestre
Copy link
Contributor 


---- tests::iso_8601::test_space_sep stdout ----
thread 'tests::iso_8601::test_space_sep' panicked at 'assertion failed: `(left == right)`
  left: `1613389067`,
 right: `1613371067`', src/lib.rs:139:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@yuankunzhang
Copy link
Contributor Author

Hi @cakebaker , please help review this PR, thanks.

@cakebaker cakebaker merged commit 03cff2c into uutils:main Jun 14, 2025
17 checks passed
@cakebaker
Copy link
Collaborator

Thanks!

@codecov Codecov
Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1a6a6f6) to head (3fe06c0).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff     @@
##   main   #150   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

m1y accepted as a valid date (while GNU version rejects it)
4 participants
@yuankunzhang @drinkcat @sylvestre @cakebaker