Skip to content

fix: timestamp cannot be combined with other items #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: timestamp cannot be combined with other items #174

wants to merge 1 commit into from
+77 −22

Conversation

yuankunzhang
Copy link
Contributor

Closes #156 .

@yuankunzhang yuankunzhang changed the title refactor: introduce a builder and simplify the date time composition fix: timestamp cannot be combined with other items Jun 30, 2025
@yuankunzhang yuankunzhang force-pushed the exclusive-timestamp branch 3 times, most recently from 8e9318f to 564d21d Compare June 30, 2025 14:45
@cakebaker
Copy link
Collaborator

There are some conflicts :|

@yuankunzhang yuankunzhang force-pushed the exclusive-timestamp branch from 564d21d to 4d6568b Compare July 1, 2025 13:40
@yuankunzhang
Copy link
Contributor Author

There are some conflicts :|

Fixed.

cakebaker
cakebaker reviewed Jul 1, 2025
View reviewed changes
src/items/mod.rs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that Timestamp is still a variant of Item with the changes of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamp values cannot be combined with other date items
2 participants
@yuankunzhang @cakebaker