(jiff series #6) refactor: replace chrono with jiff #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a066cfc to
06d3a2d
Compare
06d3a2d to
0715ed9
Compare
cakebaker
reviewed
Aug 18, 2025
cakebaker
reviewed
Aug 18, 2025
cakebaker
reviewed
Aug 18, 2025
cakebaker
reviewed
Aug 18, 2025
5e6c855 to
89a94c2
Compare
89a94c2 to
ae25053
Compare
cakebaker
reviewed
Aug 20, 2025
Comment on lines
+192
to
+198
| // #[test] | ||
| // fn test_epoch_seconds_non_utc() { | ||
| // env::set_var("TZ", "EST"); | ||
| // let dt = "@1613371067"; | ||
| // let actual = parse_datetime(dt).unwrap(); | ||
| // assert_eq!(actual.timestamp().as_second(), TEST_TIME); | ||
| // } |
There was a problem hiding this comment.
I guess this test can be removed?
There was a problem hiding this comment.
We can revisit it after this PR is done.
|
Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=====================================
Coverage ? 0
=====================================
Files ? 0
Lines ? 0
Branches ? 0
=====================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.