Various improvements to the docs and tests #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
commented
Sep 23, 2023
tests/simple.rs
Outdated
| @@ -1 +1,32 @@ | |||
| use chrono::{Duration, Local,Weekday}; | |||
| use parse_datetime::{parse_datetime_at_date, parse_relative_time::parse_relative_time, parse_timestamp::parse_timestamp, parse_weekday::parse_weekday}; | |||
There was a problem hiding this comment.
I am not a big fan of the parse_relative_time::parse_relative_time duplication
any idea how to improve this ?
bc11183 to
2a419fb
Compare
7a39b38 to
fade16a
Compare
|
@philolo1 feel free to review :) |
|
I don't think we should expose these functions. See my comment here: #33 (comment) |
|
makes sense, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.