implemented mkswap #292
Open
implemented mkswap #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i guess you saw that a bunch of jobs are failing |
|
It is proving more difficult than expected to make it successfully not work on non-linux platforms :D |
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a minimal version of the mkswap utility for Linux, including a basic swap signature initialization and several tests to cover error and success scenarios. Key changes include:
- Addition of new tests for mkswap in tests/by-util/test_mkswap.rs and tests/tests.rs.
- Implementation of the mkswap functionality in src/uu/mkswap/src/mkswap.rs.
- Updates to Cargo.toml files and documentation to integrate the new utility into the workspace.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tests.rs | Added mkswap test module to conditionally compile tests. |
| tests/by-util/test_mkswap.rs | Introduced tests covering various mkswap error and success cases. |
| src/uu/mkswap/src/mkswap.rs | Implemented the core mkswap functionality and swap signature logic. |
| src/uu/mkswap/src/main.rs | Defined the main entry point for the new mkswap utility. |
| src/uu/mkswap/mkswap.md | Added basic documentation for mkswap usage. |
| src/uu/mkswap/Cargo.toml | Provided package configuration for mkswap. |
| Cargo.toml | Updated workspace dependencies to include the mkswap package. |
Comments suppressed due to low confidence (1)
src/uu/mkswap/src/mkswap.rs:97
- Consider checking that the label length does not exceed the 16-byte buffer size before copying to avoid a potential buffer overflow. For example, truncate the label if its length is greater than 16.
(*swap_hdr).volume_name.as_mut_ptr().copy_from(label.as_ptr(), label.len());
…ng logic, removed assertions, made pagesize immutable.
dezgeg
reviewed
May 8, 2025
dezgeg
reviewed
May 8, 2025
dezgeg
reviewed
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minimal implementation of mkswap
features lacking from the original:
tested on an archiso with an 8GB swap partition