Make Options::apply fallible #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
500a487 to
c711166
Compare
|
Changes since initial push:
|
c711166 to
b2e8f73
Compare
|
Changes since last push: |
This was referenced Mar 29, 2024
b2e8f73 to
acb3f57
Compare
|
Changes since last push:
|
acb3f57 to
cf04aea
Compare
|
Changes since last push:
|
This was referenced May 9, 2024
cf04aea to
e2cdf41
Compare
tertsdiepraam
requested changes
May 20, 2024
tests/coreutils/date.rs
Outdated
| enum Iso8601Format { | ||
| #[default] | ||
| #[value("date")] | ||
| // TODO: Express the concept "accepts prefixes" more nicely. |
There was a problem hiding this comment.
I thought I built this into Value already? It's working here for example:
uutils-args/tests/coreutils/ls.rs
Line 480 in a3ecc62
There was a problem hiding this comment.
You're right! Fixed
|
|
||
| impl Options<Arg> for Settings { | ||
| fn apply(&mut self, arg: Arg) -> Result<(), uutils_args::Error> { | ||
| if self.chosen_format != Format::Unspecified { |
There was a problem hiding this comment.
So, I take a bit of issue with this example, because I don't like how Unspecified is a special thing that only exists for parsing. Essentially, it comes down to this: #11.
BUT! I don't care enough to block this. We can improve this later and we should move towards shipping this crate.
e2cdf41 to
66e1992
Compare
|
Changes since last push:
The clippy failure will be fixed by #125. Sorry, didn't see that it's my turn! |
tertsdiepraam
approved these changes
Apr 1, 2025
Also, exhausting tests.
This causes CI failures, so let's fix this.
66e1992 to
e3f0b52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows one way we could make
Options::applyfallible.This feature trivially enables error prioritization, e.g. raising different errors for
--a=invalid --b=invalidand--b=invalid --a=invalid, which is what the GNU tools do.Closes #112