remove 'complete' feature flag, make it unconditional #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids using cfg with the destination-crate's feature "complete"
in proc-macro "derive".
Quoting cargo:
using a cfg inside a derive macro will use the cfgs from the
destination crate and not the ones from the defining crate
In these two instances, the cfg was simply used to avoid emitting dead
code if the "complete" feature is not desired. By passing the "complete"
feature down to the derive crate and evaluating if there, we achieve the
same goal, without having to deal with suprisingly-valued and unexpected
cfgs downstream.
Alternatively, we could just evaluate the flag inside the derive crate,
and pass the feature flag to it.
This was referenced Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids using cfg with the destination-crate's feature "complete" in proc-macro "derive".
Quoting cargo:
In these two instances, the cfg was simply used to avoid emitting dead code if the "complete" feature is not desired.
By passing the "complete" feature down to the derive crate and evaluating if there, we achieve the same goal, without having to deal with suprisingly-valued and unexpected cfgs downstream.(EDIT: this sentence was a copy-paste-error, my bad!)Discovered while trying to integrate uutils-args into coreutils: https://github.com/uutils/coreutils/actions/runs/14420666926/job/40442804575?pr=7739
This is my preferred approach.
Alternatively, we could just evaluate the flag inside the derive crate, and pass the feature flag to it, as implemented in #132.