Skip to content

Update graphviz-java version to 0.5.3 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2018
Merged

Update graphviz-java version to 0.5.3 #60

merged 1 commit into from
Jul 25, 2018

Conversation

gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Jul 25, 2018 •
edited
Loading

Related issue: #58.

vanniktech
vanniktech approved these changes Jul 25, 2018
View reviewed changes
Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Also wanted to do that today as I saw they fixed their issue.

@vanniktech vanniktech changed the title bump graphviz-java version Update graphviz-java version to 0.5.3 Jul 25, 2018
@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage     89.58%   89.58%           
  Complexity       31       31           
=========================================
  Files             5        5           
  Lines            96       96           
  Branches         17       17           
=========================================
  Hits             86       86           
  Misses            5        5           
  Partials          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee07479...3a0a7fc. Read the comment docs.

@vanniktech vanniktech merged commit c0c589c into vanniktech:master Jul 25, 2018
@gengjiawen
Copy link
Contributor Author

Can we release a new version today, I have been wait for this a long time. Thanks.

@vanniktech
Copy link
Owner

@gengjiawen AFAIK there's no need for a new version as you can work around with it like this:

buildscript {
  repositories {
    mavenCentral()
  }
  dependencies {
    classpath "guru.nidi:graphviz-java:0.5.3"
    classpath "com.vanniktech:gradle-dependency-graph-generator-plugin:0.5.0"
  }
}

I want to get some more things into 0.6.0 before releasing.

@gengjiawen
Copy link
Contributor Author

Thanks for the tip. I also realized I can use snapshot version. But your solution is cleaner.

@vanniktech vanniktech mentioned this pull request Aug 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gengjiawen @vanniktech