Skip to content

refactor!: Rename repo_dir to dir #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2022
Merged

refactor!: Rename repo_dir to dir #324

merged 2 commits into from
Apr 10, 2022

Conversation

tony
Copy link
Member

@tony tony commented Apr 10, 2022

repo_dir param is renamed to dir:

Before: GitRepo(url='...', repo_dir='...')

After: GitRepo(url='...', dir='...')

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #324 (2369a2d) into master (6c649bc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   85.62%   85.62%           
=======================================
  Files          18       18           
  Lines         960      960           
=======================================
  Hits          822      822           
  Misses        138      138           
Impacted Files Coverage Δ
libvcs/shortcuts.py 100.00% <ø> (ø)
tests/states/test_hg.py 95.23% <ø> (ø)
libvcs/states/base.py 100.00% <100.00%> (ø)
libvcs/states/git.py 76.77% <100.00%> (ø)
libvcs/states/hg.py 100.00% <100.00%> (ø)
libvcs/states/svn.py 64.51% <100.00%> (ø)
tests/states/test_base.py 100.00% <100.00%> (ø)
tests/states/test_git.py 99.38% <100.00%> (ø)
tests/states/test_svn.py 96.15% <100.00%> (ø)
tests/test_shortcuts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c649bc...2369a2d. Read the comment docs.

@tony tony added the refactor internal code change label Apr 10, 2022
@tony tony linked an issue Apr 10, 2022 that may be closed by this pull request
2 tasks
@tony tony removed a link to an issue Apr 10, 2022
2 tasks
@tony tony merged commit 6daa714 into master Apr 10, 2022
@tony tony deleted the rename-repo-dir-to-dir branch April 10, 2022 22:41
@tony tony added this to the v0.12 milestone May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor internal code change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant